Skip to content

Moved Format and Check to their own jobs to reduce mail notifications for deployment approval #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robgruen wants to merge 5 commits into from
Closed

Moved Format and Check to their own jobs to reduce mail notifications for deployment approval #148

robgruen wants to merge 5 commits into from

Conversation

@robgruen
Copy link
Collaborator

@robgruen robgruen commented Jan 2, 2026

Less jobs awaiting approval with this layout:

image

@robgruen robgruen mentioned this pull request Jan 2, 2026
Merged
@robgruen
Update CI job name format
b4a9359 
Removed task name from CI workflow job name.
gvanrossum
gvanrossum reviewed Jan 2, 2026
View reviewed changes
.github/workflows/ci.yml Outdated
on:
push:
branches: [ "main" ]
branches: [ "main", "dev/robgruen/workflow_update3" ]
Copy link
Collaborator

@gvanrossum gvanrossum Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robgruen Can you delete your branch from the list? Then I can merge it for you. (If I were to make the change myself we might end up in a situation where only a 3rd owner can merge it...)

Copy link
Collaborator

@gvanrossum gvanrossum Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also un-draft it. But only when you're happy with this step. (I am!)

Copy link
Collaborator Author

@robgruen robgruen Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@robgruen robgruen marked this pull request as ready for review January 4, 2026 00:45
@gvanrossum
Copy link
Collaborator

gvanrossum commented Jan 4, 2026

Closing in favor of #151.

@gvanrossum gvanrossum closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robgruen @gvanrossum